Fix SEGFAULT in BMI when removing a port #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 issues with the code: * The FD_CLR call had been moved after the memset of the bmi_port_t structure, which means that we were not clearing the file descriptor at all. * We should not close the file descriptor while the select call is on-going, it is undefined behavior. We introduce a socketpair so that the thread removing the port can notify the select thread and wait for an acknowledgement before closing the file descriptor.
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
+ Coverage 74.68% 74.69% +0.01%
==========================================
Files 115 115
Lines 9894 9894
==========================================
+ Hits 7389 7390 +1
+ Misses 2505 2504 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 issues with the code:
structure, which means that we were not clearing the file descriptor
at all.
on-going, it is undefined behavior. We introduce a socketpair so that
the thread removing the port can notify the select thread and wait
for an acknowledgement before closing the file descriptor.